Changeset 787

Timestamp:

01/19/12 16:04:14 (4 months ago)

Author:

litwan

Message:

fixes issues from changing the parent class

Files:

• resource-types/ipn-listener/src/java/com/litwan/yanel/impl/resources/ipnlistener/IPNListener.java (modified) (2 diffs)

resource-types/ipn-listener/src/java/com/litwan/yanel/impl/resources/ipnlistener/IPNListener.java

@@ -97 +97 @@
     protected String paypalMessage_invoice;
     
-    /**
-     * check if the transaction should be executed or not.
-     * override in subclass if an other test is wished 
-     * 
-     * @param String response. 
-     * @return boolean. true if the response matches the expectation otherwise false 
-     */
-    protected boolean checkPreconditions(String response) {
-        if (response == null) {
-            return false;
-        }
-        
-        try {
-            double paymentAmount = 0;
-            if (paypalMessage_mc_gross != null) {
-                paymentAmount = Double.parseDouble(paypalMessage_mc_gross);
-            }
-            if (paypalMessage_mc_gross_1 != null) {
-                paymentAmount = Double.parseDouble(paypalMessage_mc_gross_1);
-            }
-            String expectedRecieverEmail = getResourceConfigProperty("expected-reciever-email");
-            String expectedPaymentCurrency = getResourceConfigProperty("expected-payment-currency");
-            
-            //check notification validation
-            if(response.equals("VERIFIED")) {
-                // check that paymentStatus=Completed
-                if (!paypalMessage_payment_status.equals("Completed")) {
-                    if (log.isInfoEnabled()) log.info("IPN Status: not Completed: " + paypalMessage_payment_status);
-                    return false;
-                }
-                // check that txnId has not been previously processed
-                if (transactionIdExists(paypalMessage_txn_id)) {
-                    log.warn("IPN Status: txnId ("+ paypalMessage_txn_id +") already exists.");
-                    return false;
-                }
-                // check that receiverEmail is your Primary PayPal email
-                if (!expectedRecieverEmail.equals(paypalMessage_receiver_email)) {
-                    log.warn("IPN Status: our paypal email is not the recivers email.");
-                    return false;
-                }
-                // check that paymentAmount/paymentCurrency are correct
-                if (getExpectedPaymentAmount() != paymentAmount) {
-                    log.warn("IPN Status: the order total (" + getExpectedPaymentAmount() + ") is not equals the payment amount (" + paymentAmount + ").");
-                    return false;
-                }
-                if (!paypalMessage_mc_currency.equals(expectedPaymentCurrency)) {
-                    log.error("IPN Status: the currency (" + paypalMessage_mc_currency + ") is not the expected "+ expectedPaymentCurrency +".");
-                    return false;
-                }
-                //if everthing is ok
-                if (log.isInfoEnabled()) log.info("seems to be alright, executig and setting transaction id as proceded");
-                return true;
-            }
-            else if(response.equals("INVALID")) {
-                log.error("PayPal: INVALID ipn request. response was: " + response);
-                return false;
-            }
-            else {
-                log.error("PayPal: no valid response for ipn verification. response was: " + response);
-                return false;
-            }      
-        } catch (Exception e) {
-            log.error(e.getMessage(), e);
-            return false;
-        }
-    }
-
-    /**
-     * check if the transaction id already exists or not.
-     * implement in subclass! 
-     * 
-     * @param String txnId. the transaction id to check.
-     * @return boolean. true if transaction already exits.
-     */
-    protected boolean transactionIdExists(String txnId) {
-        log.error("not implemented yet. please implement in sublcass");
-        return false;
-    }
-
-    /**
-     * method to receive the expected payment amount.
-     * implement in subclass!
-     *  
-     * @return double. expected paymend amount
-     */
-    protected double getExpectedPaymentAmount() {
-        log.error("not implemented yet. please implement in sublcass");
-        return 0.0;
-    }
-    
-    /**
-     * 
-     */
-    protected void execute() {
-        log.error("not implemented yet. please implement in sublcass");
-    }    
-    
-    /**
-     * this method allows for example to set the transaction id to exist
-     * implement in subclass!
-     * 
-     */
-    protected void postExecute() {
-        log.error("not implemented yet. please implement in sublcass");
-    }
-    
-    @Override
-    public InputStream getContentXML(String viewID) throws Exception {
-        init();
-        if (checkPreconditions(verifyRequest())) {
-            execute();
-            postExecute();
-        }
-        return super.getContentXML(viewID);
-    }
-
+    
     protected void init() {
+
         //String paymentStatus = getParameterAsString("payment_status");
         paypalMessage_receiver_email = getParameterAsString("receiver_email");
@@ -256 +142 @@
         paypalMessage_verify_sign = getParameterAsString("verify_sign");
         paypalMessage_invoice = getParameterAsString("invoice");
-    }
+        
+        if (checkPreconditions(verifyRequest())) {
+            execute();
+            postExecute();
+        }        
+    }
+    
+    /**
+     * check if the transaction should be executed or not.
+     * override in subclass if an other test is wished 
+     * 
+     * @param String response. 
+     * @return boolean. true if the response matches the expectation otherwise false 
+     */
+    protected boolean checkPreconditions(String response) {
+        if (response == null) {
+            return false;
+        }
+        
+        try {
+            double paymentAmount = 0;
+            if (paypalMessage_mc_gross != null) {
+                paymentAmount = Double.parseDouble(paypalMessage_mc_gross);
+            }
+            if (paypalMessage_mc_gross_1 != null) {
+                paymentAmount = Double.parseDouble(paypalMessage_mc_gross_1);
+            }
+            String expectedRecieverEmail = getResourceConfigProperty("expected-reciever-email");
+            String expectedPaymentCurrency = getResourceConfigProperty("expected-payment-currency");
+            
+            //check notification validation
+            if(response.equals("VERIFIED")) {
+                // check that paymentStatus=Completed
+                if (!paypalMessage_payment_status.equals("Completed")) {
+                    if (log.isInfoEnabled()) log.info("IPN Status: not Completed: " + paypalMessage_payment_status);
+                    return false;
+                }
+                // check that txnId has not been previously processed
+                if (transactionIdExists(paypalMessage_txn_id)) {
+                    log.warn("IPN Status: txnId ("+ paypalMessage_txn_id +") already exists.");
+                    return false;
+                }
+                // check that receiverEmail is your Primary PayPal email
+                if (!expectedRecieverEmail.equals(paypalMessage_receiver_email)) {
+                    log.warn("IPN Status: our paypal email is not the recivers email.");
+                    return false;
+                }
+                // check that paymentAmount/paymentCurrency are correct
+                if (getExpectedPaymentAmount() != paymentAmount) {
+                    log.warn("IPN Status: the order total (" + getExpectedPaymentAmount() + ") is not equals the payment amount (" + paymentAmount + ").");
+                    return false;
+                }
+                if (!paypalMessage_mc_currency.equals(expectedPaymentCurrency)) {
+                    log.error("IPN Status: the currency (" + paypalMessage_mc_currency + ") is not the expected "+ expectedPaymentCurrency +".");
+                    return false;
+                }
+                //if everthing is ok
+                if (log.isInfoEnabled()) log.info("seems to be alright, executig and setting transaction id as proceded");
+                return true;
+            }
+            else if(response.equals("INVALID")) {
+                log.error("PayPal: INVALID ipn request. response was: " + response);
+                return false;
+            }
+            else {
+                log.error("PayPal: no valid response for ipn verification. response was: " + response);
+                return false;
+            }      
+        } catch (Exception e) {
+            log.error(e.getMessage(), e);
+            return false;
+        }
+    }
+
+    /**
+     * check if the transaction id already exists or not.
+     * implement in subclass! 
+     * 
+     * @param String txnId. the transaction id to check.
+     * @return boolean. true if transaction already exits.
+     */
+    protected boolean transactionIdExists(String txnId) {
+        log.error("not implemented yet. please implement in sublcass");
+        return false;
+    }
+
+    /**
+     * method to receive the expected payment amount.
+     * implement in subclass!
+     *  
+     * @return double. expected paymend amount
+     */
+    protected double getExpectedPaymentAmount() {
+        log.error("not implemented yet. please implement in sublcass");
+        return 0.0;
+    }
+    
+    /**
+     * 
+     */
+    protected void execute() {
+        log.error("not implemented yet. please implement in sublcass");
+    }    
+    
+    /**
+     * this method allows for example to set the transaction id to exist
+     * implement in subclass!
+     * 
+     */
+    protected void postExecute() {
+        log.error("not implemented yet. please implement in sublcass");
+    }
+    
+//    @Override
+//    public InputStream getContentXML(String viewID) throws Exception {
+//        init();
+//        return super.getContentXML(viewID);
+//    }
+
+ 
     
     /**